Fix softioc system test #229
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GDYendell
reviewed
Oct 13, 2025
GDYendell
reviewed
Oct 13, 2025
| # we need to capture log messages from transport | ||
| logger = _logger.bind(logger_name="fastcs.transport.epics.ca.transport") | ||
| logger.add(print) # forward log messages to stdout | ||
|
|
There was a problem hiding this comment.
This is all that is required
diff --git a/tests/conftest.py b/tests/conftest.py
index df850933..0af1e703 100644
--- a/tests/conftest.py
+++ b/tests/conftest.py
@@ -15,13 +15,12 @@ from uuid import uuid4
import pytest
from aioca import purge_channel_caches
-from loguru import logger as _logger
from softioc import builder
from fastcs.attributes import AttrR, AttrRW, AttrW
from fastcs.datatypes import Bool, Float, Int, String
from fastcs.launch import build_controller_api
-from fastcs.logging import LogLevel, configure_logging
+from fastcs.logging import logger
from fastcs.transport.tango.dsr import register_dev
from tests.assertable_controller import MyTestAttributeIORef, MyTestController
from tests.example_p4p_ioc import run as _run_p4p_ioc
@@ -88,10 +87,9 @@ def _run_ioc_as_subprocess(
error_queue: multiprocessing.Queue,
stdout_queue: multiprocessing.Queue,
):
- configure_logging(LogLevel.INFO)
# we need to capture log messages from transport
- logger = _logger.bind(logger_name="fastcs.transport.epics.ca.transport")
logger.add(print) # forward log messages to stdout
+ logger.enable("fastcs")
try:
from pytest_cov.embed import cleanup_on_sigterm
There was a problem hiding this comment.
It still hangs on my end with this fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #228
Small fix needed due to changes in logging messages that softioc system tests wait for before timing out. Also have removed src from the doctests for now as the Tracer docstring was being collected and failing under pytest.